----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30790/#review71759 -----------------------------------------------------------
This looks really good. I had a couple of thoughts on the design, let me know what you think. server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java <https://reviews.apache.org/r/30790/#comment117630> Perhaps "ROLES" instead? server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java <https://reviews.apache.org/r/30790/#comment117634> roles/grant? server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java <https://reviews.apache.org/r/30790/#comment117631> roles/revoke? server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java <https://reviews.apache.org/r/30790/#comment117632> privileges/grant? server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java <https://reviews.apache.org/r/30790/#comment117633> privileges/revoke server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java <https://reviews.apache.org/r/30790/#comment117628> 'default' case? Maybe throw an exception? server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java <https://reviews.apache.org/r/30790/#comment117627> 'default' case? Maybe throw an exception? - Abraham Elmahrek On Feb. 9, 2015, 9:07 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30790/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2015, 9:07 a.m.) > > > Review request for Sqoop and shen guoquan. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Handle Rest API in server side to grant/revoke role, etc. > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/json/PrincipalBean.java PRE-CREATION > common/src/main/java/org/apache/sqoop/json/PrincipalsBean.java PRE-CREATION > common/src/main/java/org/apache/sqoop/json/PrivilegeBean.java PRE-CREATION > common/src/main/java/org/apache/sqoop/json/PrivilegesBean.java PRE-CREATION > common/src/main/java/org/apache/sqoop/json/RoleBean.java PRE-CREATION > common/src/main/java/org/apache/sqoop/json/RolesBean.java PRE-CREATION > core/src/main/java/org/apache/sqoop/security/SecurityError.java > 322a98f1f148d7544c7fe5e9a84ef8e9b6618612 > > server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java > PRE-CREATION > server/src/main/java/org/apache/sqoop/server/AuthorizationServlet.java > PRE-CREATION > server/src/main/java/org/apache/sqoop/server/RequestHandler.java > bd62f31eac3e47c2eb085f836383f98b17260d2f > server/src/main/webapp/WEB-INF/web.xml > 85ae26ba0839dd897527c9fe13e4e56c84d43ecc > > Diff: https://reviews.apache.org/r/30790/diff/ > > > Testing > ------- > > local > > > Thanks, > > richard zhou > >
