[ 
https://issues.apache.org/jira/browse/SQOOP-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317315#comment-14317315
 ] 

Abraham Elmahrek commented on SQOOP-2099:
-----------------------------------------

The test cases missed this because they aren't full integration tests. The way 
I verified this fix is by configuring Sqoop2 and running a job.
{code:title=sqoop.properties}
org.apache.sqoop.repository.jdbc.handler=org.apache.sqoop.repository.postgresql.PostgresqlRepositoryHandler
org.apache.sqoop.repository.jdbc.transaction.isolation=READ_COMMITTED
org.apache.sqoop.repository.jdbc.maximum.connections=10
org.apache.sqoop.repository.jdbc.url=jdbc:postgresql://.../...                  
                                                                                
                                                                                
                                                  
org.apache.sqoop.repository.jdbc.driver=org.postgresql.Driver
org.apache.sqoop.repository.jdbc.user=...
org.apache.sqoop.repository.jdbc.password=...
{code}

{code:title=test.sqoop}
set option --name verbose --value true
show connector
create link --cid 4 --name mysql --link-linkConfig-connectionString 
jdbc:mysql://.../... --link-linkConfig-username ... --link-linkConfig-password 
... --link-linkConfig-jdbcDriver com.mysql.jdbc.Driver
create link --cid 3 --name hdfs
create job --from 1 --to 2 --name mysql2hdfs --from-fromJobConfig-tableName fl 
--to-toJobConfig-outputFormat TEXT_FILE --to-toJobConfig-compression NONE 
--to-toJobConfig-outputDirectory /tmp/sqoop2/hdfs
{code}

> Sqoop2: detectRepositoryVersion uses wrong casing
> -------------------------------------------------
>
>                 Key: SQOOP-2099
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2099
>             Project: Sqoop
>          Issue Type: Bug
>          Components: sqoop2-postgresql-repository
>    Affects Versions: 1.99.5
>            Reporter: Abraham Elmahrek
>            Assignee: Abraham Elmahrek
>             Fix For: 1.99.5
>
>         Attachments: SQOOP-2099.0.patch
>
>
> Notice the use of {{toLowerCase()}} below:
> {code}
> metadataResultSet = md.getTables(null,
>           CommonRepositorySchemaConstants.SCHEMA_SQOOP.toLowerCase(),
>           CommonRepositorySchemaConstants.TABLE_SQ_SYSTEM_NAME.toLowerCase(), 
> null);
> {code}
> This was done before we were escaping all identifiers. Now that SQOOP-2041 is 
> in, we shouldn't be doing this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to