----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30980/ -----------------------------------------------------------
Review request for Sqoop. Repository: sqoop-sqoop2 Description ------- Currenly when the Tomcat Sqoop miniCluster started, it at firstly will need to download the tomcat.tar.gz. When the Tomcat tar package has been successfully downloaded, it will load the sqoop war package. That's is the problem. For example, When the sentry want to do some integration tests with sqoop, Sentry want to use the Tomcat Sqoop miniCluster to test, it must download the sqoop war package in its project. It is not the correct way. The correct method is that when Sentry want to do integration tests with Sqoop, it only to do is add a maven dependency in the pom, then it can use a independent sqoop miniCluster to test. Diffs ----- dist/pom.xml e0bf0d0 pom.xml d48389e server/pom.xml ee409cb test/pom.xml f743d25 test/src/main/java/org/apache/sqoop/test/minicluster/JettySqoopMiniCluster.java PRE-CREATION test/src/main/java/org/apache/sqoop/test/minicluster/JettySqoopRunner.java PRE-CREATION test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java 398a051 test/src/main/java/org/apache/sqoop/test/testcases/JettyTestCase.java PRE-CREATION test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/DerbyRepositoryUpgradeTest.java a687c16 test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java a54492e Diff: https://reviews.apache.org/r/30980/diff/ Testing ------- Thanks, shen guoquan
