----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31127/#review72769 -----------------------------------------------------------
pom.xml <https://reviews.apache.org/r/31127/#comment118841> does not this need a license update? if so please indicate that and not sure if we need a new RB to update LICENSE.txt - Veena Basavaraj On Feb. 17, 2015, 11:17 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31127/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 11:17 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2109 > https://issues.apache.org/jira/browse/SQOOP-2109 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > There has been several things that I had to fix in order to get this right: > > * Shell packaging was pulling in all dependencies regardless of their scope, > I had to manually switch it from "test" to "runtime" > * Common was directly depending on common-test without properly specifying > testing scope > * Security module was completely missing dependency on com.bueust (that > wasn't problem because 2) has pulled it in transitively) > > > Diffs > ----- > > common/pom.xml 9e593b2e23d54db34ad5737c08637365792e6537 > pom.xml d48389ee60c1fbc5fa76e85a577d48f1e2032aec > security/pom.xml e4e61ccaa43aa62c7db66fe72ade3bc25b4155aa > shell/pom.xml e48c86a20f0bb5bf0ba8a5f12d563bb4c6f0f26a > > Diff: https://reviews.apache.org/r/31127/diff/ > > > Testing > ------- > > I've run the packaging target and the shell/lib directory size decreased from > 46MB to 28MB (almost a half!), excluding all the testing dependencies. > > > Thanks, > > Jarek Cecho > >
