> On Feb. 18, 2015, 11:42 p.m., Abraham Elmahrek wrote:
> > common/src/main/java/org/apache/sqoop/json/JobConfigInputBean.java, lines
> > 55-61
> > <https://reviews.apache.org/r/31173/diff/1/?file=868583#file868583line55>
> >
> > Default case? Or just return an empty object is sufficient? Maybe throw
> > a runtime exception?
>
> Veena Basavaraj wrote:
> there is no need since if one of the expected is not given an exception
> is already thrown if you see the code above it should become clear
This same answer repeats in all the places where this has been asked
if (!MConfigType.getSubTypes(MConfigType.JOB).contains(configSubType)) {
throw new SqoopException(ServerError.SERVER_0006);
}
- Veena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31173/#review73095
-----------------------------------------------------------
On Feb. 18, 2015, 5:15 p.m., Veena Basavaraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31173/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 5:15 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2113
> https://issues.apache.org/jira/browse/SQOOP-2113
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/error/code/ServerError.java
> 86cca7dcc9c7ea0f69b279dd85d3e68a1eda6596
> common/src/main/java/org/apache/sqoop/json/JobBean.java
> 0561adebd3b604b27512e22227db076712f27fd0
> common/src/main/java/org/apache/sqoop/json/JobConfigInputBean.java
> PRE-CREATION
> common/src/main/java/org/apache/sqoop/json/JsonBean.java
> 1dd275e80df25b3521bb20dd31e4e2221db50ff8
> common/src/main/java/org/apache/sqoop/json/LinkBean.java
> 2e2406f3de35294896e280b57d505197a6d6af86
> common/src/main/java/org/apache/sqoop/json/LinkConfigInputBean.java
> PRE-CREATION
>
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java
> ffaf041baed67974b76f3b789b14414ec487a0a4
> common/src/main/java/org/apache/sqoop/model/ConfigUtils.java
> dd6e9ce481c12b7d096f4e8473acbdb2f04eee90
> common/src/test/java/org/apache/sqoop/json/TestJobConfigInputBean.java
> PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/TestLinkConfigInputBean.java
> PRE-CREATION
> common/src/test/java/org/apache/sqoop/json/util/ConfigTestUtil.java
> fbc7faa3a24810952fd22d30b69ee1e983e04547
>
> server/src/main/java/org/apache/sqoop/handler/ConfigInputRequestHandler.java
> PRE-CREATION
> server/src/main/java/org/apache/sqoop/server/v1/ConfigInputServlet.java
> PRE-CREATION
> server/src/main/webapp/WEB-INF/web.xml
> 60ee8c4acace2aaab8909f5c6daa6600875f7794
>
> Diff: https://reviews.apache.org/r/31173/diff/
>
>
> Testing
> -------
>
> done
>
>
> Thanks,
>
> Veena Basavaraj
>
>
