-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31163/
-----------------------------------------------------------
(Updated Feb. 20, 2015, 12:09 a.m.)
Review request for Sqoop and Jarek Cecho.
Bugs: SQOOP-1978
https://issues.apache.org/jira/browse/SQOOP-1978
Repository: sqoop-sqoop2
Description
-------
commit 3a863cec531aa30880fca866794a397729f2b69f
Author: Abraham Elmahrek <[email protected]>
Date: Fri Feb 13 09:46:41 2015 -0800
SQOOP-1978: Sqoop2: Command line support
:100644 100644 1ef2418... a16ba5b... M
shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java
:000000 100644 0000000... 10d06b5... A
shell/src/main/java/org/apache/sqoop/shell/CreateRoleFunction.java
:100644 100644 26e2bf6... 4b66505... M
shell/src/main/java/org/apache/sqoop/shell/DeleteCommand.java
:000000 100644 0000000... d3c9f4d... A
shell/src/main/java/org/apache/sqoop/shell/DeleteRoleFunction.java
:000000 100644 0000000... b4b77b0... A
shell/src/main/java/org/apache/sqoop/shell/GrantCommand.java
:000000 100644 0000000... a473628... A
shell/src/main/java/org/apache/sqoop/shell/GrantPrivilegeFunction.java
:000000 100644 0000000... 9dfe90f... A
shell/src/main/java/org/apache/sqoop/shell/GrantRoleFunction.java
:000000 100644 0000000... 0cb30e4... A
shell/src/main/java/org/apache/sqoop/shell/RevokeCommand.java
:000000 100644 0000000... 16c6bf9... A
shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java
:000000 100644 0000000... cf69faa... A
shell/src/main/java/org/apache/sqoop/shell/RevokeRoleFunction.java
:100644 100644 cbd34f5... fdb7a5b... M
shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java
:100644 100644 2e87965... e319839... M
shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java
:100644 100644 46f2b7f... 8133bd6... M
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
:100644 100644 9c88235... ca64dae... M
shell/src/main/resources/shell-resource.properties
Diffs (updated)
-----
shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java 1ef2418
shell/src/main/java/org/apache/sqoop/shell/CreateRoleFunction.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/DeleteCommand.java 26e2bf6
shell/src/main/java/org/apache/sqoop/shell/DeleteRoleFunction.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/GrantCommand.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/GrantPrivilegeFunction.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/GrantRoleFunction.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/RevokeCommand.java PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/RevokeRoleFunction.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java cbd34f5
shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java 2e87965
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 482ddd9
shell/src/main/resources/shell-resource.properties a462184
Diff: https://reviews.apache.org/r/31163/diff/
Testing
-------
mvn test
Manually tested with the following commands:
create role -r abe
delete role -r abe
grant role --principal-type user --principal abe -r abe
revoke role --principal-type user --principal abe -r abe
grant privilege --resource-type connector --resource abe -a read
--principal abe --principal-type user -g
grant privilege --resource-type connector --resource abe -a read
--principal abe --principal-type user
revoke privilege --resource-type connector --resource abe -a read
--principal abe --principal-type user -g
revoke privilege --resource-type connector --resource abe -a read
--principal abe --principal-type user
You can check the logs for the appropriate server response.
These tests will be better once we have a backend integrated.
Thanks,
Abraham Elmahrek
