----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30699/#review73293 -----------------------------------------------------------
Ship it! Ship It! - Jarek Cecho On Feb. 5, 2015, 10:24 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30699/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 10:24 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1841 > https://issues.apache.org/jira/browse/SQOOP-1841 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit aa8aba0d9b28d4e07d8ea31c118b300b8aba091b > Author: Abraham Elmahrek <[email protected]> > Date: Wed Feb 4 23:33:59 2015 -0800 > > SQOOP-1841: Sqoop2: Upgrade from 1.99.1 to 1.99.4 onwards is broken > > :100644 100644 c991e5c... f066727... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > :100644 100644 ce7b6cb... a242ff9... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java > :100644 100644 606fc68... bf61208... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java > > > Diffs > ----- > > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > c991e5c > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaInsertUpdateDeleteSelectQuery.java > ce7b6cb > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java > 606fc68 > > Diff: https://reviews.apache.org/r/30699/diff/ > > > Testing > ------- > > Manually tested that the upgrade from 1.99.2 installation to 1.99.5 trunk > (latest for sqoop2) gets beyond constraint manipulation. The existence of > duplicate names is a problem that will need to be addressed in SQOOP-1790. > > > Thanks, > > Abraham Elmahrek > >
