----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31383/#review74118 -----------------------------------------------------------
One comment: repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java <https://reviews.apache.org/r/31383/#comment120639> I'm wondering if there is a reason to use function instead of the static strings that we have in this file? It seems that we should be able to do one static string that will be base and then two strings - one for direction and another without, right? Jarcec - Jarek Cecho On Feb. 25, 2015, 1:19 a.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31383/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 1:19 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1790 > https://issues.apache.org/jira/browse/SQOOP-1790 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit 2389610b2de431294ee7691e6af266c102f25e67 > Author: Abraham Elmahrek <[email protected]> > Date: Mon Feb 23 16:17:25 2015 -0800 > > SQOOP-1790: Sqoop2: Upgrade configs with name conflicts > > :100644 100644 6e85c03... 87af723... M > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java > :100644 100644 220e42e... 2a3ab9b... M > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java > :100644 100644 6a23fc2... 042b526... M > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java > :100644 100644 6e183de... 545b990... M > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java > :100644 100644 1b1270e... 7af912d... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > :100644 100644 2e780ff... ff9798c... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java > :000000 100644 0000000... 36502cb... A > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyUpgradeGenericJdbcConnectorConfigAndInputNames.java > :000000 100644 0000000... 849ab7b... A > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java > :000000 100644 0000000... bf9bf85... A > test/src/test/resources/repository/derby/derby-repository-1.99.3.tar.gz > > > Diffs > ----- > > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java > 6e85c03 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnectorUpgrader.java > 220e42e > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java > 6a23fc2 > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositorySchemaConstants.java > 6e183de > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 1b1270e > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java > 2e780ff > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyUpgradeGenericJdbcConnectorConfigAndInputNames.java > PRE-CREATION > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_3UpgradeTest.java > PRE-CREATION > test/src/test/resources/repository/derby/derby-repository-1.99.3.tar.gz > PRE-CREATION > > Diff: https://reviews.apache.org/r/31383/diff/ > > > Testing > ------- > > Added a 1.99.3 upgrade test. > Manually tested working upgrade: > 1. Was able to start server after upgrade > 2. Was able to run job. > > > Thanks, > > Abraham Elmahrek > >
