----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31575/#review75288 -----------------------------------------------------------
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopBaseAuthorizable.java <https://reviews.apache.org/r/31575/#comment122267> why do define this abstract class? I think we just need to follow current sentry's code style. It means Job implements SqoopAuthorizable - Xiaomeng Huang On 三月 5, 2015, 2:33 a.m., shen guoquan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31575/ > ----------------------------------------------------------- > > (Updated 三月 5, 2015, 2:33 a.m.) > > > Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, > Dapeng Sun, and Prasad Mujumdar. > > > Repository: sentry > > > Description > ------- > > Add the authorizable model in Sentry for Sqoop role-based authorizaiton > integration > > > Diffs > ----- > > pom.xml 4c80916 > sentry-core/pom.xml 1552133 > sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION > > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java > PRE-CREATION > > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java > PRE-CREATION > > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java > PRE-CREATION > > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java > PRE-CREATION > > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java > PRE-CREATION > > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java > PRE-CREATION > > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java > PRE-CREATION > > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopBaseAuthorizable.java > PRE-CREATION > > sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java > PRE-CREATION > > sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java > PRE-CREATION > sentry-dist/pom.xml f63b33b > > Diff: https://reviews.apache.org/r/31575/diff/ > > > Testing > ------- > > Ran included unit tests. > > > Thanks, > > shen guoquan > >
