-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31803/#review75512
-----------------------------------------------------------



test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java
<https://reviews.apache.org/r/31803/#comment122642>

    I think this could use hdfsClient.getUri().getAuthority() instead of string 
manipulation.



test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java
<https://reviews.apache.org/r/31803/#comment122645>

    Kite doesn't allow CSV as an output format except using a special property 
used internally for testing. That's because there are a lot of structures that 
can't be represented as CSV and Kite doesn't support any hacks to represent the 
data (i.e., field delimiters).
    
    Is this actually writing CSV through Kite? If so, how?


- Ryan Blue


On March 6, 2015, 10:22 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31803/
> -----------------------------------------------------------
> 
> (Updated March 6, 2015, 10:22 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2157
>     https://issues.apache.org/jira/browse/SQOOP-2157
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Added simple integration test for Kite connector.
> 
> 
> Diffs
> -----
> 
>   
> connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java
>  a9cff77 
>   
> test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/31803/diff/
> 
> 
> Testing
> -------
> 
> The test passes.
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>

Reply via email to