----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31831/#review76576 -----------------------------------------------------------
Ship it! Ship It! - Abraham Elmahrek On March 16, 2015, 3:59 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31831/ > ----------------------------------------------------------- > > (Updated March 16, 2015, 3:59 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1805 > https://issues.apache.org/jira/browse/SQOOP-1805 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > I've added incremental options similar to Sqoop 1 and alter our partitioning > function to take advantage of them. The method was relatively hard to change, > so I've ended up rewriting it completely. > > The connector is not persisting the last values back to configuration object > as the functionality is not exposed by Sqoop yet. > > > Diffs > ----- > > > common/src/main/java/org/apache/sqoop/error/code/GenericJdbcConnectorError.java > 03bc104 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java > 4369071 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java > 7a01992 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java > 1ecd152 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfiguration.java > 39e8edd > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/IncrementalRead.java > PRE-CREATION > > connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-config.properties > 6a2159b > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java > 52003ab > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestGenericJdbcConnector.java > PRE-CREATION > > test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/31831/diff/ > > > Testing > ------- > > I've added several new unit tests and integration test for the newly added > functionality. > > > Thanks, > > Jarek Cecho > >
