> On March 17, 2015, 7:29 p.m., Abraham Elmahrek wrote: > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToInitializer.java, > > line 55 > > <https://reviews.apache.org/r/32153/diff/1/?file=897598#file897598line55> > > > > +1: MasterOfOrion?
Nice catch! For some reason I've miss remembered this one. I'll fix that shortly. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32153/#review76779 ----------------------------------------------------------- On March 17, 2015, 6 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32153/ > ----------------------------------------------------------- > > (Updated March 17, 2015, 6 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1738 > https://issues.apache.org/jira/browse/SQOOP-1738 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > I've added checks to ensure that output directory either don't exists or is > empty. Otherwise the job will fail on submission. > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/error/code/HdfsConnectorError.java > 8514541 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java > ad500c2 > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToInitializer.java > PRE-CREATION > > test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/32153/diff/ > > > Testing > ------- > > Added unit and integration tests. > > > Thanks, > > Jarek Cecho > >
