----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32216/#review76949 -----------------------------------------------------------
Might be cool to make this configurable for HDFS encryption/ACLs? connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToDestroyer.java <https://reviews.apache.org/r/32216/#comment124684> Why not move entire directory? instead of file at a time. connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToDestroyer.java <https://reviews.apache.org/r/32216/#comment124681> Debug maybe. connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java <https://reviews.apache.org/r/32216/#comment124686> Not opposed to it... but these probably can be removed since they're only useful for debugging - Abraham Elmahrek On March 18, 2015, 8:48 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32216/ > ----------------------------------------------------------- > > (Updated March 18, 2015, 8:48 p.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Implemented as per description in JIRA. > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/error/code/HdfsConnectorError.java > c85e7fc > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConstants.java > bd74bec > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsLoader.java > 0ced6d0 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToDestroyer.java > 3c85be8 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java > 83bac27 > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestLoader.java > b7c81ec > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToDestroyer.java > PRE-CREATION > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToInitializer.java > 1daa25a > > Diff: https://reviews.apache.org/r/32216/diff/ > > > Testing > ------- > > I've added unit tests for new functionality. Existing integration tests > passes without any changes (which is a positive thing here). > > > Thanks, > > Jarek Cecho > >
