----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32226/#review76996 -----------------------------------------------------------
Two nits: connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnectorUpgrader.java <https://reviews.apache.org/r/32226/#comment124749> Nit: Seems like copy&pasted code from ConfigurableUpgradeUtil. Do you think that it would make sense to simply reuse the same method and simply move the config value that we know? Something like: // Move properties that did not change name ConfigurableUpgradeUtil.doUpgrade(original.getConfigs(), upgradeTarget.getConfigs()); // Move properties that have been renaed for(Map.Entry<String, String> entry: LINK_CONFIG_MAP) { upgradeTarget.getInput(entry.getKey()).setValue(original.getInput(entry.getValue()).getValue()); } connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteConnectorUpgrader.java <https://reviews.apache.org/r/32226/#comment124748> Nit:Let's not use JUnit bridge in new tests? - Jarek Cecho On March 19, 2015, 1:44 a.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32226/ > ----------------------------------------------------------- > > (Updated March 19, 2015, 1:44 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2231 > https://issues.apache.org/jira/browse/SQOOP-2231 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit 7741c9def364a705c880a8bda664878d85f218d7 > Author: Abraham Elmahrek <[email protected]> > Date: Wed Mar 18 16:40:08 2015 -0700 > > SQOOP-2231: Sqoop2: Kite connector should use authority in link > configuration > > :100644 100644 745460f... ccb7e13... M > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnectorUpgrader.java > :100644 100644 d48e250... 94a9e3a... M > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ConfigUtil.java > :100644 100644 c40092d... ee31f15... M > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/LinkConfig.java > :000000 100644 0000000... 741c81e... A > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteConnectorUpgrader.java > > > Diffs > ----- > > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteConnectorUpgrader.java > 745460f > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ConfigUtil.java > 1df1859 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/LinkConfig.java > c40092d > > connector/connector-kite/src/main/resources/kite-connector-config.properties > 23d0e28 > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteConnector.java > PRE-CREATION > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteConnectorUpgrader.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/32226/diff/ > > > Testing > ------- > > Manual testing > > > Thanks, > > Abraham Elmahrek > >
