----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32250/#review77086 -----------------------------------------------------------
One nit: dist/src/main/server/conf/sqoop.properties <https://reviews.apache.org/r/32250/#comment124932> I'm not sure that we want debug output in production for all thoose classes? - Jarek Cecho On March 19, 2015, 6:41 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32250/ > ----------------------------------------------------------- > > (Updated March 19, 2015, 6:41 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1998 > https://issues.apache.org/jira/browse/SQOOP-1998 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit 95f8da94bb1f9b4a4baf5811c3a668e9d31733b7 > Author: Abraham Elmahrek <[email protected]> > Date: Wed Mar 18 00:49:33 2015 -0700 > > SQOOP-1998: Sqoop2: Kite Hive > > :100644 100644 11ec534... 8593899... M connector/connector-kite/pom.xml > :100644 100644 883925b... db8d4e6... M > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java > :100644 100644 41fe7e1... e03bd60... M > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetPartitioner.java > :100644 100644 d4a8a77... d93f9b5... M > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteExtractor.java > :100644 100644 292510a... 06f18e7... M > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteFromInitializer.java > :100644 100644 57790a1... ca0a5c7... M > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteLoader.java > :100644 100644 187ad21... 39a2989... M > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java > :100644 100644 3052a87... e63bccf... M > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ConfigUtil.java > :100644 100644 7173c18... 44721a8... M > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteExecutor.java > :100644 100644 b18c91e... 533b8c3... M > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteLoader.java > :100644 100644 45fcb5e... 31111cd... M > dist/src/main/server/conf/catalina.properties > :100755 100755 e7de613... 5d292fd... M > dist/src/main/server/conf/sqoop.properties > :100644 100644 3d7434e... e3431bd... M pom.xml > :100644 100644 1d4e7e6... 8a21b06... M > test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java > > > Diffs > ----- > > connector/connector-kite/pom.xml 11ec534 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetExecutor.java > 883925b > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteDatasetPartitioner.java > 41fe7e1 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteExtractor.java > d4a8a77 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteFromInitializer.java > 292510a > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteLoader.java > 57790a1 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/KiteToInitializer.java > 187ad21 > > connector/connector-kite/src/main/java/org/apache/sqoop/connector/kite/configuration/ConfigUtil.java > 3052a87 > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteExecutor.java > 7173c18 > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteFromInitializer.java > a60b2fc > > connector/connector-kite/src/test/java/org/apache/sqoop/connector/kite/TestKiteLoader.java > b18c91e > dist/src/main/server/conf/catalina.properties 45fcb5e > dist/src/main/server/conf/sqoop.properties e7de613 > pom.xml 3d7434e > > Diff: https://reviews.apache.org/r/32250/diff/ > > > Testing > ------- > > Only tested manually. Integration tests in a follow up Jira. > > Be aware of SQOOP-2237, SQOOP-2229 and SQOOP-2238. > > > Thanks, > > Abraham Elmahrek > >
