> On March 24, 2015, 9:05 a.m., Jarek Cecho wrote: > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/IncrementalWriteMode.java, > > lines 17-20 > > <https://reviews.apache.org/r/32415/diff/2/?file=903464#file903464line17> > > > > It seems that the UPSERT is not implemented yet, so I would suggest to > > not expose such configuration option to the user and "comment it out" > > similarly as we have for the "DELETE" example. > > > > (unless you will add it in subsequent patch as mentioned on the JIRA). > > Veena Basavaraj wrote: > yes I added a prelim patch to get a early feedback, but that plan is to > add it, so a select will be done before to see if it exists and then do a > update / insert
after discussions in JIRA that the "merge" is not consistently implemented standard by the most prominent Dbs, dropped the upsert use case > On March 24, 2015, 9:05 a.m., Jarek Cecho wrote: > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java, > > lines 151-154 > > <https://reviews.apache.org/r/32415/diff/2/?file=903462#file903462line151> > > > > I think that we should expose ability for user to specify an > > updateColumn in case that the table doesn't have a primary key. I know that > > it sounds unlikely, but I've seen a lot of users that actually had such > > environments and need to export data into them. > > > > Also I think that we should add support for composite primary keys / > > update columns (e.g. if we need to identify the update row based on > > multiple columns). > > Veena Basavaraj wrote: > can you elabborate more? > > is the idea to validate the updateByColumn, at the time config values are > added? > > adding composite seems like a good idea, might be a good enhancement, > since at this point it is hard to simulate that use case in the current > integration test to add more support for such tables. > > So I new ticket to enhace functionality would be good. have renamed the type to UPDATE_BY_COLUN, so in future a new one UPDATE_BY_COMPOSITE key can be added. I have create a new ticket for this feature. I am not sure what should be the format of such a compounf key, comma separated or a list? do provide your inputs on it. - Veena ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32415/#review77562 ----------------------------------------------------------- On March 25, 2015, 1:18 p.m., Veena Basavaraj wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32415/ > ----------------------------------------------------------- > > (Updated March 25, 2015, 1:18 p.m.) > > > Review request for Sqoop and Jarek Cecho. > > > Bugs: SQOOP-1810 > https://issues.apache.org/jira/browse/SQOOP-1810 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > see JIRA for details on tests > > > Diffs > ----- > > > common/src/main/java/org/apache/sqoop/error/code/GenericJdbcConnectorError.java > f18acbd > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java > a5cd715 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcLoader.java > 22b726e > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java > c2515a5 > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/IncrementalWriteConfig.java > PRE-CREATION > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/IncrementalWriteMode.java > PRE-CREATION > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java > fd5d54b > > connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-config.properties > 52bf631 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestLoader.java > 3a73691 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java > 17bac77 > > Diff: https://reviews.apache.org/r/32415/diff/ > > > Testing > ------- > > see JIRA for details on tests > > > Thanks, > > Veena Basavaraj > >
