----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32427/#review77811 -----------------------------------------------------------
Ship it! Looks good except for NPE server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java <https://reviews.apache.org/r/32427/#comment126102> This can return null? server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java <https://reviews.apache.org/r/32427/#comment126103> NPE is possible with out check. server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java <https://reviews.apache.org/r/32427/#comment126104> Watch NPE server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java <https://reviews.apache.org/r/32427/#comment126105> Watch NPE - Abraham Elmahrek On March 25, 2015, 7:17 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32427/ > ----------------------------------------------------------- > > (Updated March 25, 2015, 7:17 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > When getting multi-connectors/links/jobs, AuthorizationEngine.filterResource > is used to filter resources according to the permissions. > When getting one specific connector/link/job via id, this resource should be > checked permission, and throw exception if no privilege. > > > Diffs > ----- > > > security/src/main/java/org/apache/sqoop/security/Authorization/AuthorizationEngine.java > d261027ff5aefa728c5f761534f4439264b4ae45 > server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java > 2305a51472a0201771fe493e8364f7db62ee79a2 > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > 0c5f1f216e9e6a42bd24c226dbca18cacd4f5c55 > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java > 3187bcf00b51533cc33513a315dd9f1296e58c6d > > Diff: https://reviews.apache.org/r/32427/diff/ > > > Testing > ------- > > manual > > > Thanks, > > richard zhou > >
