-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32563/
-----------------------------------------------------------
Review request for Sqoop.
Repository: sqoop-sqoop2
Description
-------
Use getFromLinkId and getToLinkId, instead of getLinkId(Direction).
Similar with Job and Connector
Since the following code:
public MConfigList getJobConfig(Direction type) {
switch(type) {
case FROM:
return fromConfig;
case TO:
return toConfig;
default:
throw new SqoopException(DirectionError.DIRECTION_0000, "Direction: " +
type);
}
}
public MFromConfig getFromJobConfig() {
return fromConfig;
}
public MToConfig getToJobConfig() {
return toConfig;
}
If getJobConfig(Direction type) is used, down casting is a MUST for all usage,
such as:
MToConfig toConfigList = (MToConfig) job.getJobConfig(Direction.To);
So we decide to use getFromLinkId/getToLinkId instead of getLinkId(Direction).
Diffs
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java
81c7558e2092f885b3a921dfa9dbd258263f0584
common/src/main/java/org/apache/sqoop/json/JobBean.java
0561adebd3b604b27512e22227db076712f27fd0
common/src/main/java/org/apache/sqoop/model/MJob.java
1c241038369b5454f7a63ee89e0c35341ab8268c
common/src/test/java/org/apache/sqoop/json/TestJobBean.java
68a4ca7610c060fd62433bb4aadf62ffd37ead22
common/src/test/java/org/apache/sqoop/json/TestJobsBean.java
2dffb060a9b17d921246038dd898a829f59c9853
common/src/test/java/org/apache/sqoop/model/TestMJob.java
336dfb5f457c6c5fcf38c0708f167dac58e9c3b2
core/src/main/java/org/apache/sqoop/driver/JobManager.java
4609c1b06bd1102e12e75db4bf155c47454fe192
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
039524a0c57b48d1c785aad61d9e5f93dd6da6f6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
9ed762705f078b68d20a8ba0abbc3a428e0c361b
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
b889b85eefe1ba450cb7e5ddba2d18668a0f9c35
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/PostgresqlTestCase.java
34dbd8ce02bfb30d1f1ef5a44ece9e884be43270
repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java
5d3d46f3fd5c8a7366d2bb370678006132e6e8cf
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
e22b1e891566c28a89b8a511d31bd71a861179a6
shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java
be5ddce3dc5402242c98f9bcdc7eb8fff9a3b827
shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java
47ad5fff02b1f32e684b16f60abc341ed11c46e1
shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java
ba8fcf31552e0cce33b65971d82481efcedbddab
shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java
02e8c8c480c38aa70af40d5387b44faf8157701c
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java
94384415a2728ca82a79afc77b44a946e87aa1bc
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java
a1f512ba9ebb964e7ba4e4b560a06211ee681cc5
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicConfigOptions.java
49b09c7f7470c7d1e63bfb044bc701cf1e75a429
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java
94e8c7aa03b9ec446a94c45699f3caaec64884c6
test/src/main/java/org/apache/sqoop/test/testcases/KafkaConnectorTestCase.java
b1bfb363e48b99493b5a38cc181cae13a7298d2a
test/src/test/java/org/apache/sqoop/integration/connector/hdfs/AppendModeTest.java
89405e67539b4708ad36b8806d328418c2b687f2
test/src/test/java/org/apache/sqoop/integration/connector/hive/FromRDBMSToKiteHiveTest.java
e789ce0f564c4cd058328af011c7d4c404519543
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/AllTypesTest.java
740732fa78871177ffbc451e382a3e330c027618
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java
b5baf87b9bcdeaadf6b953bf807bd792a6582395
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java
e36283e5c4464f96ce9727d404f750f90baba4c7
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java
5c2428d15687810c3dcc7b957d411750dd549b2c
test/src/test/java/org/apache/sqoop/integration/connector/kite/FromRDBMSToKiteTest.java
828d244c35244c1ad2ced2b71fb3d0af0ee13a3b
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java
e13cf1e0e7c78b8a569b0d83b8e47ac0978608b3
Diff: https://reviews.apache.org/r/32563/diff/
Testing
-------
manual test, integration test
Thanks,
richard zhou
