----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32588/#review78164 -----------------------------------------------------------
connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java <https://reviews.apache.org/r/32588/#comment126673> I'm not particularly familiar with this code, so forgive me if my question doesn't make much sense here. It seems to me that we're doing quite a lot if-elses and castings to simply get Number object to i'ts corresponding string representation. Wouldn't be simpler to just do: return obj.toString()? - Jarek Cecho On March 27, 2015, 10:14 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32588/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 10:14 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2213 > https://issues.apache.org/jira/browse/SQOOP-2213 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit 4bee6231efff20cad14303628fc3a18db38ecc6b > Author: Abraham Elmahrek <[email protected]> > Date: Fri Mar 27 12:13:47 2015 -0700 > > SQOOP-2213: Sqoop2: toCSVFixedPoint ClassCastException > > :100644 100644 c460f80... 2a7aa1b... M > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java > :100644 100644 f99d1af... 0819f92... M > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/common/TestSqoopIDFUtils.java > > > Diffs > ----- > > > connector/connector-sdk/src/main/java/org/apache/sqoop/connector/common/SqoopIDFUtils.java > c460f80 > > connector/connector-sdk/src/test/java/org/apache/sqoop/connector/common/TestSqoopIDFUtils.java > f99d1af > > Diff: https://reviews.apache.org/r/32588/diff/ > > > Testing > ------- > > mvn test > > > Thanks, > > Abraham Elmahrek > >
