> On April 30, 2015, 1:42 a.m., Jarek Cecho wrote: > > dist/src/main/server/conf/sqoop.properties, lines 175-178 > > <https://reviews.apache.org/r/33708/diff/1/?file=945994#file945994line175> > > > > I believe that the URLClassLoader doesn't accept directories with jars > > - it expects every jar explicitly enumerated. > > > > If I'm not mistaken, then the directories are considering as complied > > code and hence they will be searched only for .class files without looking > > into any archives.
Just making this comment specific to jars. - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33708/#review82070 ----------------------------------------------------------- On April 30, 2015, 12:21 a.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33708/ > ----------------------------------------------------------- > > (Updated April 30, 2015, 12:21 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2342 > https://issues.apache.org/jira/browse/SQOOP-2342 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit 85fd8cc9826207f94d14645fbcfec8a5b37102da > Author: Abraham Elmahrek <[email protected]> > Date: Wed Apr 29 17:17:27 2015 -0700 > > SQOOP-2342: Sqoop2: Provide an external application classloader > > :100644 100644 24e73c3... 4690a30... M > common/src/main/java/org/apache/sqoop/error/code/CoreError.java > :100644 100644 49e5d6f... a0e4984... M > core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java > :100644 100644 15ee12f... ff9a29e... M > core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java > :100755 100755 5226a19... 424d3cb... M > dist/src/main/server/conf/sqoop.properties > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/error/code/CoreError.java 24e73c3 > core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java > 49e5d6f > core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java 15ee12f > dist/src/main/server/conf/sqoop.properties 5226a19 > > Diff: https://reviews.apache.org/r/33708/diff/ > > > Testing > ------- > > manually tested that new jars are being loaded. > > > Thanks, > > Abraham Elmahrek > >
