> On May 7, 2015, 9:46 a.m., Abraham Elmahrek wrote: > > src/test/com/cloudera/sqoop/hive/TestHiveImport.java, lines 296-314 > > <https://reviews.apache.org/r/33104/diff/4-5/?file=948229#file948229line296> > > > > Why not just create a Set object and compare sets? It should be much > > less code.
We will not able to test a dataset with duplicated records, if we use set instead of list. `List.remove` will remove the first matched element. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33104/#review82786 ----------------------------------------------------------- On May 6, 2015, 1:49 p.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33104/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 1:49 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2295 > https://issues.apache.org/jira/browse/SQOOP-2295 > > > Repository: sqoop-trunk > > > Description > ------- > > Currently, an existing dataset will throw an exception. This differs from > `--as-textfile`. I've checked the user manual, the handling of HDFS and Hive > are indeed different. For HDFS, unless `--append` is specified, the job will > fail when destination exists already. For Hive, unless `--create-hive-table` > is specified, the job will become append mode. The patch has made the > handling of `--as-textfile` and `--as-parquetfile` consistent. > > > Diffs > ----- > > src/docs/man/hive-args.txt 7d9e427 > src/docs/man/sqoop-create-hive-table.txt 7aebcc1 > src/docs/user/create-hive-table.txt 3aa34fd > src/docs/user/hive-args.txt 53de92d > src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java d5bfae2 > src/java/org/apache/sqoop/mapreduce/ParquetJob.java df55dbc > src/test/com/cloudera/sqoop/TestParquetImport.java 07e140a > src/test/com/cloudera/sqoop/hive/TestHiveImport.java fa717cb > src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 7934791 > src/test/com/cloudera/sqoop/testutil/ImportJobTestCase.java 293bf10 > testdata/hive/scripts/normalImportAsParquet.q e434e9b > > Diff: https://reviews.apache.org/r/33104/diff/ > > > Testing > ------- > > Manually tested append, new create and overwrite cases. > > > Thanks, > > Qian Xu > >
