----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34700/#review85525 -----------------------------------------------------------
LGTM except for one nit. See below. Will test this out locally as well. src/java/org/apache/sqoop/tool/CodeGenTool.java <https://reviews.apache.org/r/34700/#comment137094> seems weird. if `newClassName` can be null, then it shouldn't be appended to a string? - Abraham Elmahrek On May 28, 2015, 5 a.m., Qian Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34700/ > ----------------------------------------------------------- > > (Updated May 28, 2015, 5 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2372 > https://issues.apache.org/jira/browse/SQOOP-2372 > > > Repository: sqoop-trunk > > > Description > ------- > > CodeGenTool should use the variable `tableName` instead of > `options.getTableName()`. When importing all tables, the > options.getTableName() is not set. > > > Diffs > ----- > > src/java/org/apache/sqoop/tool/CodeGenTool.java ab339ad > src/test/com/cloudera/sqoop/TestAllTables.java 39e8941 > > Diff: https://reviews.apache.org/r/34700/diff/ > > > Testing > ------- > > > Thanks, > > Qian Xu > >
