----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34883/#review86578 -----------------------------------------------------------
Ship it! Found a couple of more details while testing the patch out. shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java <https://reviews.apache.org/r/34883/#comment138636> NIT: Please don't use wildcards! shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java <https://reviews.apache.org/r/34883/#comment138635> Change message too? - Abraham Elmahrek On June 4, 2015, 2:02 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34883/ > ----------------------------------------------------------- > > (Updated June 4, 2015, 2:02 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > SQOOP2: Revoke all privilege > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/SqoopClient.java d5c4a8a > shell/src/main/java/org/apache/sqoop/shell/RevokePrivilegeFunction.java > 802d206 > > Diff: https://reviews.apache.org/r/34883/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > >
