-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34930/
-----------------------------------------------------------
(Updated June 8, 2015, 2:48 p.m.)
Review request for Sqoop.
Bugs: sqoop-2386
https://issues.apache.org/jira/browse/sqoop-2386
Repository: sqoop-sqoop2
Description
-------
In HandlerUtils, there is code like this:
if (repository.findJob(identifier) != null) {
jobId = repository.findJob(identifier).getPersistenceId();
...
}
This will execute repository.findJob twice, this is unnecessary.
Diffs
-----
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java d1537bf
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
5128a27
server/src/main/java/org/apache/sqoop/handler/HandlerUtils.java 93ff60b
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java c96d66d
Diff: https://reviews.apache.org/r/34930/diff/
Testing
-------
Thanks,
Dian Fu
