[
https://issues.apache.org/jira/browse/SQOOP-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14581398#comment-14581398
]
Sqoop QA bot commented on SQOOP-2395:
-------------------------------------
Testing file
[SQOOP-2395.2.patch|https://issues.apache.org/jira/secure/attachment/12738976/SQOOP-2395.2.patch]
against branch sqoop2 took 0:38:43.572739.
{color:red}Overall:{color} -1 due to an error
{color:red}ERROR:{color} Patch does not add/modifny any test case
{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All fast unit tests passed (executed 682 tests)
{color:green}SUCCESS:{color} All slow unit tests passed (executed 1 tests)
{color:green}SUCCESS:{color} All fast integration tests passed (executed 27
tests)
{color:green}SUCCESS:{color} All slow integration tests passed (executed 42
tests)
Console output is available
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1403/console].
This message is automatically generated.
> Signature of method getConnectorIdFromIdentifier in HandlerUtils is
> inconsistent with other methods
> ---------------------------------------------------------------------------------------------------
>
> Key: SQOOP-2395
> URL: https://issues.apache.org/jira/browse/SQOOP-2395
> Project: Sqoop
> Issue Type: Bug
> Reporter: Dian Fu
> Assignee: Dian Fu
> Fix For: 1.99.7
>
> Attachments: SQOOP-2395.1.patch, SQOOP-2395.2.patch
>
>
> In HandlerUtils.java, there are three methods and the other two methods both
> take "String identifier, Repository repository" as the signature. Making
> method getConnectorIdFromIdentifier also taking "String identifier,
> Repository repository" as the signature will makes the code more consistent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
