----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35216/#review88937 -----------------------------------------------------------
Ship it! Ship It! - richard zhou On June 11, 2015, 3:05 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35216/ > ----------------------------------------------------------- > > (Updated June 11, 2015, 3:05 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2395 > https://issues.apache.org/jira/browse/SQOOP-2395 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > In HandlerUtils.java, there are three methods and the other two methods both > take "String identifier, Repository repository" as the signature. Making > method getConnectorIdFromIdentifier also taking "String identifier, > Repository repository" as the signature will makes the code more consistent. > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java d1537bf > server/src/main/java/org/apache/sqoop/handler/HandlerUtils.java 718b9e6 > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > c96d66d > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java > bf3a42a > server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java > b4c16f1 > > Diff: https://reviews.apache.org/r/35216/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > >
