[ 
https://issues.apache.org/jira/browse/SQOOP-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14597315#comment-14597315
 ] 

Richard commented on SQOOP-2395:
--------------------------------

+1. Thanks, [[email protected]], it's in.
Please also help to raise another JIRA for the following refactor which 
referred in RB.

> Sqoop2: Signature of method getConnectorIdFromIdentifier in HandlerUtils is 
> inconsistent with other methods
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-2395
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2395
>             Project: Sqoop
>          Issue Type: Bug
>            Reporter: Dian Fu
>            Assignee: Dian Fu
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2395.1.patch, SQOOP-2395.2.patch
>
>
>  In HandlerUtils.java, there are three methods and the other two methods both 
> take "String identifier, Repository repository" as the signature. Making 
> method getConnectorIdFromIdentifier also taking "String identifier, 
> Repository repository" as the signature will makes the code more consistent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to