----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36027/#review89834 -----------------------------------------------------------
src/java/org/apache/sqoop/mapreduce/ParquetJob.java (line 94) <https://reviews.apache.org/r/36027/#comment142656> hiveConf might be null but isSecureMetastore will call getBoolean on it. src/java/org/apache/sqoop/mapreduce/ParquetJob.java (line 170) <https://reviews.apache.org/r/36027/#comment142658> Shouldn't this be Class<?>? src/java/org/apache/sqoop/mapreduce/ParquetJob.java (line 175) <https://reviews.apache.org/r/36027/#comment142660> I know it's a pain, but this should catch the exceptions separately instead of catching Exception. Same for line 205. - Ryan Blue On June 29, 2015, 4:54 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36027/ > ----------------------------------------------------------- > > (Updated June 29, 2015, 4:54 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2406 > https://issues.apache.org/jira/browse/SQOOP-2406 > > > Repository: sqoop-trunk > > > Description > ------- > > commit 3ed86cf1282cd8e3c5f31728d5b15fcb7685a3c1 > Author: Abraham Elmahrek <a...@apache.org\> > Date: Fri Jun 19 14:14:13 2015 +0300 > > fetch hive delegation token > > Kite hive delegation token > > :100644 100644 a665a20... 90d75b3... M src/docs/user/hive-notes.txt > :100644 100644 7521464... 997b6be... M > src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java > :100644 100644 c775ef3... 335d9ff... M > src/java/org/apache/sqoop/mapreduce/ParquetJob.java > > > Diffs > ----- > > src/docs/user/hive-notes.txt a665a20 > src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 7521464 > src/java/org/apache/sqoop/mapreduce/ParquetJob.java c775ef3 > > Diff: https://reviews.apache.org/r/36027/diff/ > > > Testing > ------- > > Manually tested with oozie and on CLI. > > > Thanks, > > Abraham Elmahrek > >
