----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34918/#review91019 -----------------------------------------------------------
Overall looks good to me, I have just one more philosophical comment: security/src/main/java/org/apache/sqoop/security/authorization/AuthorizationEngine.java (line 45) <https://reviews.apache.org/r/34918/#comment144236> Super nit: It seems that we prefer in the code camelCase names rather then using underscores. Would it make sense to rename this variable to be consistent? Jarcec - Jarek Cecho On June 2, 2015, 2:42 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34918/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 2:42 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Add do user support in authorization engine. > > > Diffs > ----- > > > security/src/main/java/org/apache/sqoop/security/authorization/AuthorizationEngine.java > 10f02c0d4b5a0ca7ec06c9bced66808a4ba08325 > server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java > 5128a27b6a6220b7b2b94b661c2127084a6295fe > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > c96d66d8911104692289fe340074356fa6a9a01f > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java > bf3a42a99e25c8851298d9f4a3136cea3f1a2e70 > server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java > b4c16f13d242b17b6de14bb25d546ba1fd299ebf > > Diff: https://reviews.apache.org/r/34918/diff/ > > > Testing > ------- > > > Thanks, > > richard zhou > >
