----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36175/#review92702 -----------------------------------------------------------
Ship it! Seems cool! Just a few more comments and I think we're good. As a follow up, can we also add testing for this tool? And specifically this functionality? common/src/main/java/org/apache/sqoop/json/SubmissionBean.java (line 47) <https://reviews.apache.org/r/36175/#comment146942> Can we add "job-id" separately and mark "job" as deprecated (but still provide it?). I ask because consumers of this API (such as Hue can use it). tools/src/main/java/org/apache/sqoop/tools/tool/JSONConstants.java (line 34) <https://reviews.apache.org/r/36175/#comment146941> You can kill this off since it's not being used any more. - Abraham Elmahrek On July 20, 2015, 10:10 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36175/ > ----------------------------------------------------------- > > (Updated July 20, 2015, 10:10 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1256 > https://issues.apache.org/jira/browse/SQOOP-1256 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Load repository dump into a different repository > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/json/SubmissionBean.java ad05057 > tools/src/main/java/org/apache/sqoop/tools/tool/JSONConstants.java 9301707 > tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java > 1027baf > tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java > a25ebe8 > > Diff: https://reviews.apache.org/r/36175/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > >
