> On July 23, 2015, 6:30 p.m., Abraham Elmahrek wrote: > > Seems cool! Usability thought... What do you think about adding an extra > > new line after each SUCCESS, SKIP, etc.?
I was thinking about the same and I honestly have no preference. I'll add it though as it seems that more people are thinking about the same. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36721/#review92787 ----------------------------------------------------------- On July 23, 2015, 6:34 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36721/ > ----------------------------------------------------------- > > (Updated July 23, 2015, 6:34 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2424 > https://issues.apache.org/jira/browse/SQOOP-2424 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Provided TestNG listener as suggested on the JIRA. > > > Diffs > ----- > > test/src/main/java/org/apache/sqoop/test/testng/SqoopTestListener.java > PRE-CREATION > test/src/test/resources/integration-tests-suite.xml f0dd905 > test/src/test/resources/upgrade-tests-suite.xml 2856556 > > Diff: https://reviews.apache.org/r/36721/diff/ > > > Testing > ------- > > Example output: > > Running integration-tests > Test org.apache.sqoop.integration.connector.hdfs.AppendModeTest.test > running... > SUCCESS in 65 seconds > Test > org.apache.sqoop.integration.connector.jdbc.generic.FromHDFSToRDBMSTest.testBasic > running... > SUCCESS in 26 seconds > Test > org.apache.sqoop.integration.connector.jdbc.generic.TableStagedRDBMSTest.testStagedTransfer > running... > SUCCESS in 25 seconds > Test > org.apache.sqoop.integration.connector.hdfs.OutputDirectoryTest.testOutputDirectoryIsAFile > running... > SUCCESS in 0 seconds > Test > org.apache.sqoop.integration.connector.hdfs.OutputDirectoryTest.testOutputDirectoryIsEmpty > running... > SUCCESS in 27 seconds > Test > org.apache.sqoop.integration.connector.hdfs.OutputDirectoryTest.testOutputDirectoryIsNotEmpty > running... > SUCCESS in 0 seconds > Test > org.apache.sqoop.integration.connector.jdbc.generic.FromRDBMSToHDFSTest.testAllowNullsWithOneExtractor > running... > SUCCESS in 22 seconds > Test > org.apache.sqoop.integration.connector.jdbc.generic.FromRDBMSToHDFSTest.testCities > running... > SUCCESS in 28 seconds > Test > org.apache.sqoop.integration.connector.jdbc.generic.FromRDBMSToHDFSTest.testColumns > running... > > > Thanks, > > Jarek Cecho > >
