-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36918/
-----------------------------------------------------------
(Updated July 31, 2015, 3:17 p.m.)
Review request for Sqoop.
Changes
-------
I've renamed the "escape" to "enclose" as Abe suggested.
Bugs: SQOOP-2244
https://issues.apache.org/jira/browse/SQOOP-2244
Repository: sqoop-sqoop2
Description
-------
The patch is rather big as there has been a lot of things that I had to change.
I've changed the semantics on the configuration objects now - we're expecting
unescaped table/column names and we're doing the escaping whenever it's needed.
Diffs (updated)
-----
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java
cab0917
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcFromInitializer.java
20fabf6
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java
4688de3
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfiguration.java
ed55bff
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/SqlDialect.java
PRE-CREATION
connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-config.properties
52bf631
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java
22c9e15
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcTestConstants.java
8a5dba4
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java
77ac9c3
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java
6ae6f90
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestLoader.java
f192c22
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java
1c65fc3
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java
c84e799
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java
dac6db7
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/IncrementalReadTest.java
66c016d
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java
e9c4543
Diff: https://reviews.apache.org/r/36918/diff/
Testing
-------
Both unit and integration tests are passing.
Thanks,
Jarek Cecho
