----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36042/#review93948 -----------------------------------------------------------
Looks good. One more change. The SqoopJsonUtilTest has no special dependency and ideally should be run as part of ant test. Please change the name of the class to start with Test so that is automatically run as part of ant test. - Venkat Ranganathan On July 29, 2015, 11:09 p.m., Rakesh Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36042/ > ----------------------------------------------------------- > > (Updated July 29, 2015, 11:09 p.m.) > > > Review request for Sqoop and Venkat Ranganathan. > > > Bugs: SQOOP-2333 > https://issues.apache.org/jira/browse/SQOOP-2333 > > > Repository: sqoop-trunk > > > Description > ------- > > Sqoop allows users to develop their own plugins. But currently there is no > way user plugins can have their custom options. Users will have to use sqoop > predefined options. This patch adds support for a map to SqoopOptions which > opens up possibilities for users to add their custom options as key/value > pairs in the map. > > > Diffs > ----- > > src/docs/dev/SqoopDevGuide.txt a81cfda > src/docs/dev/plugin-arch.txt PRE-CREATION > src/java/org/apache/sqoop/SqoopOptions.java 9405605 > src/java/org/apache/sqoop/util/SqoopJsonUtil.java PRE-CREATION > src/test/org/apache/sqoop/util/SqoopJsonUtilTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/36042/diff/ > > > Testing > ------- > > YES > > > Thanks, > > Rakesh Sharma > >
