[ 
https://issues.apache.org/jira/browse/SQOOP-2439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662576#comment-14662576
 ] 

Jarek Jarcec Cecho commented on SQOOP-2439:
-------------------------------------------

Please feel free to take it on [[email protected]]. I'm happy to do review for 
you :)

I see why the solution #2 is simpler, even though I have concerns that we might 
"accidentally" clash with real user name. But we can easily migrate from #2 to 
#1 if we decide in the future, so we can do #1 if #2 will show up as a real 
problem.

Thinking about #2 a bit more and playing the role of devil's advocate, here is 
a few points that cross my mind:

* We should pick up the "default" username that is unlikely to clash and that 
won't confuse the users. Whereas {{dr.who}} that Hadoop is using looks really 
cool, I've seen a lot of users having troubles with it :( So using something 
like {{sqoop.anonymous.user}} or something might be a good idea.
* What about making the "default" username configurable, so that in case we 
indeed clash, administrator have ability to change it without recompiling the 
code?
* We should clearly define what are the semantics of the "default" username. 
Should we for example enable Grant/revoke statements for the default user or 
should we tread it as "you can't do anything"?

> Sqoop2: NullPointerException when calling job status notification URL
> ---------------------------------------------------------------------
>
>                 Key: SQOOP-2439
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2439
>             Project: Sqoop
>          Issue Type: Bug
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>            Priority: Blocker
>             Fix For: 1.99.7
>
>
> While working on SQOOP-2244, I've noticed {{NullPointerException}} in the 
> code unrelated to my changes:
> {code}
> 2015-07-28 18:48:48,264 ERROR server.SqoopProtocolServlet 
> [org.apache.sqoop.server.SqoopProtocolServlet.doGet(SqoopProtocolServlet.java:53)]
>  Exception in GET http://localhost:56826/sqoop//v1/job/status/notification/1
> java.lang.NullPointerException
>  at 
> org.apache.sqoop.security.authorization.AuthorizationEngine.checkPrivilege(AuthorizationEngine.java:185)
>  at 
> org.apache.sqoop.security.authorization.AuthorizationEngine.readJob(AuthorizationEngine.java:99)
>  at 
> org.apache.sqoop.handler.JobRequestHandler.getJobs(JobRequestHandler.java:312)
>  at 
> org.apache.sqoop.handler.JobRequestHandler.handleEvent(JobRequestHandler.java:104)
>  at org.apache.sqoop.server.v1.JobServlet.handleGetRequest(JobServlet.java:86)
>  at 
> org.apache.sqoop.server.SqoopProtocolServlet.doGet(SqoopProtocolServlet.java:48)
>  at javax.servlet.http.HttpServlet.service(HttpServlet.java:617)
>  at javax.servlet.http.HttpServlet.service(HttpServlet.java:723)
>  at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
>  at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
>  at 
> org.apache.hadoop.security.authentication.server.AuthenticationFilter.doFilter(AuthenticationFilter.java:572)
>  at 
> org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticationFilter.doFilter(DelegationTokenAuthenticationFilter.java:269
>  at 
> org.apache.hadoop.security.authentication.server.AuthenticationFilter.doFilter(AuthenticationFilter.java:542)
>  at 
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
>  at 
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
>  at 
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
>  at 
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
>  at 
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
>  at 
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
>  at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:615)
>  at 
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
>  at 
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293)
>  at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:861)
>  at 
> org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:606)
>  at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)
>  at java.lang.Thread.run(Thread.java:745)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to