----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37261/#review94710 -----------------------------------------------------------
test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java (line 45) <https://reviews.apache.org/r/37261/#comment149326> objec should be object. test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java (line 63) <https://reviews.apache.org/r/37261/#comment149327> I think it would be better if we can move method "assertResponseCode" out of class Validator. test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java (line 134) <https://reviews.apache.org/r/37261/#comment149328> Should be "wr.writeBytes(byteData)" instead of "wr.writeBytes(desc.data);" - Dian Fu On Aug. 8, 2015, 9:48 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37261/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2015, 9:48 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2469 > https://issues.apache.org/jira/browse/SQOOP-2469 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Added infrastructure to run arbitrary REST requests with two small tests. > Interestingly enough doing POST to /version leads to tomcat response rather > then Sqoop response which we will want to fix in future patch - I want to > keep this one simple. > > > Diffs > ----- > > > test/src/test/java/org/apache/sqoop/integration/server/InvalidRESTCallsTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/37261/diff/ > > > Testing > ------- > > The test case is passing. > > > Thanks, > > Jarek Cecho > >
