----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37015/#review94829 -----------------------------------------------------------
Ship it! If this is working, I'm +1. dev-support/test-patch.py (line 422) <https://reviews.apache.org/r/37015/#comment149471> A note on python style: if not summary: ... Would also work! - Abraham Elmahrek On Aug. 1, 2015, 5:26 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37015/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2015, 5:26 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2450 > https://issues.apache.org/jira/browse/SQOOP-2450 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Rather then waiting on resolving SQOOP-2448 (all findbugs errors), I've > decided to provide solution that will only report newly introduced findbugs > warnings. > > > Diffs > ----- > > dev-support/test-patch.py 4bd5a7d > > Diff: https://reviews.apache.org/r/37015/diff/ > > > Testing > ------- > > I did testing on my local box and it seems to be working :) > > > Thanks, > > Jarek Cecho > >
