[ 
https://issues.apache.org/jira/browse/SQOOP-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692296#comment-14692296
 ] 

Sqoop QA bot commented on SQOOP-2442:
-------------------------------------

Testing file 
[SQOOP-2442.patch|https://issues.apache.org/jira/secure/attachment/12749911/SQOOP-2442.patch]
 against branch sqoop2 took 0:59:07.702860.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 687 tests)
{color:green}SUCCESS:{color} Test coverage did not decreased 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1529/artifact/patch-process/cobertura_report.txt])
{color:green}SUCCESS:{color} All integration tests passed (executed 71 tests)

Console output is available 
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1529/console].

This message is automatically generated.

> Sqoop2: Generic JDBC: Drop tests for specifying schema name and custom SQL at 
> the same time
> -------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-2442
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2442
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2442.patch
>
>
> We currently have [bunch of 
> tests|https://github.com/apache/sqoop/blob/sqoop2/connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java#L195]
>  that are verifying the case when user specifies custom schema and custom SQL 
> query. This combination however doesn't make sense as we're not using schema 
> option when using custom query and we're even having an explicit [check for 
> that in the 
> validator|https://github.com/apache/sqoop/blob/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java#L66].



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to