On Aug. 11, 2015, 2:09 p.m., richard zhou wrote: > > Thanks for submitting a patch for this! I know my review has a lot of > > comments, but I wanted to put all of my thoughts out there. Feel free to > > discuss any of them.
Hey, Grant Henke, I real appreciate that you have left so many comments, which are very valuable. I will update the patch according to your comments soon. - richard ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35591/#review94911 ----------------------------------------------------------- On Aug. 4, 2015, 8:25 a.m., richard zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35591/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 8:25 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > This is an initial patch. It may not work currently. Please check whether > this design of framework is fine or not. > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/error/code/KafkaConnectorErrors.java > 436b852b0c69258753d7f09c3411bc19d16957a3 > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaConnector.java > e3eafe87f7376031d79fec76739fd9e648df872b > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaConstants.java > 9d3877db4ab53b09aec34511be6a29cc28611f63 > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaExtractor.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaFromDestroyer.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaFromInitializer.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaPartition.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/KafkaPartitioner.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/FromJobConfig.java > PRE-CREATION > > connector/connector-kafka/src/main/java/org/apache/sqoop/connector/kafka/configuration/FromJobConfiguration.java > PRE-CREATION > > connector/connector-kafka/src/main/resources/kafka-connector-config.properties > d3e1e6f3f0de8bae60ac22bbf718dddd8330362a > > Diff: https://reviews.apache.org/r/35591/diff/ > > > Testing > ------- > > Passed compile, but it still needs to be tested in the real cluster. > > > Thanks, > > richard zhou > >
