----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34509/#review95275 -----------------------------------------------------------
Ship it! Overall, looks good. I'm +1 if this passes pre-commit hook. I know that it's currently broken - I'm trying to get it fixed in SQOOP-2476. test/src/main/java/org/apache/sqoop/test/utils/HdfsUtils.java <https://reviews.apache.org/r/34509/#comment150130> We should still keep this method around right? Jarcec - Jarek Cecho On Aug. 13, 2015, 1:36 a.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34509/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2015, 1:36 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2364 > https://issues.apache.org/jira/browse/SQOOP-2364 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit d5117886e7be68c6a40fb28cd4c0020fab977052 > Author: Abraham Elmahrek <[email protected]> > Date: Fri May 15 16:10:17 2015 -0700 > > SQOOP-2364: Sqoop2: Provide test infrastructure base class for server > tests > > :100644 100644 758eb2f... 6a286ae... M > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java > :100644 100644 5a6773d... 38444c0... M > test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java > :100644 100644 79700a6... 786cf40... M > test/src/main/java/org/apache/sqoop/test/utils/HdfsUtils.java > :000000 100644 0000000... f4eeb88... A > test/src/main/java/org/apache/sqoop/test/utils/RdbmsUtils.java > :000000 100644 0000000... 2aeeb72... A > test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java > :100644 100644 40dc7d7... a1858d7... M > test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java > :100644 100644 a54492e... a14d12e... M > test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java > > > Diffs > ----- > > test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java > e60caf7 > > test/src/main/java/org/apache/sqoop/test/minicluster/InProcessSqoopMiniCluster.java > e11e82c > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java > 758eb2f > > test/src/main/java/org/apache/sqoop/test/minicluster/TomcatSqoopMiniCluster.java > 9f7301b > test/src/main/java/org/apache/sqoop/test/utils/HdfsUtils.java 79700a6 > > test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java > 199b77c > test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java > bcaf5f5 > > Diff: https://reviews.apache.org/r/34509/diff/ > > > Testing > ------- > > mvn clean integration-test (but only for the server tests) > > > Thanks, > > Abraham Elmahrek > >
