----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37474/#review95402 -----------------------------------------------------------
core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java (line 71) <https://reviews.apache.org/r/37474/#comment150342> Seems that this method is never used. We can just remove it. - Dian Fu On Aug. 14, 2015, 7:19 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37474/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2015, 7:19 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Fix smaller-ish warnings in core module > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java 728127b > core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java a16fceb > > core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java > f1c4820 > core/src/main/java/org/apache/sqoop/core/SqoopServer.java e78e4d9 > core/src/main/java/org/apache/sqoop/driver/JobManager.java d4e0655 > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java c09b77b > > core/src/main/java/org/apache/sqoop/repository/JdbcTransactionIsolation.java > 2b1c8ce > core/src/main/java/org/apache/sqoop/repository/Repository.java 8cbff99 > > Diff: https://reviews.apache.org/r/37474/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
