> On Aug. 14, 2015, 7:31 a.m., Dian Fu wrote: > > LGTM. A minor issue: In method RequestContext#getUserName(), there is code > > like this: > > AuthenticationManager.getAuthenticationHandler().isSecurityEnabled(). This > > should be fixed accordingly too. > > Dian Fu wrote: > Should also change all reference to > AuthorizationManager.getAuthorizationHandler() accordingly too. > > Colin Ma wrote: > Sorry, the patch miss some files. I'll update the patch soon.
+1 to the latest patch. - Dian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37472/#review95398 ----------------------------------------------------------- On Aug. 14, 2015, 7:42 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37472/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2015, 7:42 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > There has some problems when using singleton pattern in AuthenticationManager > and AuthorizationManager. > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/security/AuthenticationManager.java > 603643f > core/src/main/java/org/apache/sqoop/security/AuthorizationManager.java > 7699862 > > security/src/main/java/org/apache/sqoop/security/authorization/AuthorizationEngine.java > 57e0da5 > > server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java > a730413 > server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java > 0d06085 > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java > f056686 > server/src/main/java/org/apache/sqoop/server/RequestContext.java 01aed41 > > Diff: https://reviews.apache.org/r/37472/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
