> On Aug. 15, 2015, 4:18 p.m., Jarek Cecho wrote: > > Nice, good catch! Just a few high level questions:
Thanks for the comments, the patch is updated and take advantage of try-with-resources. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37473/#review95520 ----------------------------------------------------------- On Aug. 18, 2015, 1:46 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37473/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2015, 1:46 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Fix resource leak problem in SqoopConfiguration and ConnectorManagerUtils > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/connector/ConnectorManagerUtils.java > 7402c5a > core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java 49f139c > > Diff: https://reviews.apache.org/r/37473/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
