[ 
https://issues.apache.org/jira/browse/SQOOP-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14705700#comment-14705700
 ] 

Sqoop QA bot commented on SQOOP-2441:
-------------------------------------

Testing file 
[SQOOP-2441.patch|https://issues.apache.org/jira/secure/attachment/12751519/SQOOP-2441.patch]
 against branch sqoop2 took 0:56:35.476701.

{color:green}Overall:{color} +1 all checks pass

{color:green}SUCCESS:{color} Clean was successful
{color:green}SUCCESS:{color} Patch applied correctly
{color:green}SUCCESS:{color} Patch add/modify test case
{color:green}SUCCESS:{color} License check passed
{color:green}SUCCESS:{color} Patch compiled
{color:green}SUCCESS:{color} All unit tests passed (executed 1404 tests)
{color:orange}WARNING:{color} Test coverage has decreased 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1608/artifact/patch-process/cobertura_report.txt])
* Package {{shell}}: Can't compare test coverage as base is missing.
* Package {{execution/mapreduce}}: Can't compare test coverage as base is 
missing.
* Package {{server}}: Can't compare test coverage as base is missing.
* Package {{core}}: Can't compare test coverage as base is missing.
* Package {{tools}}: Can't compare test coverage as base is missing.
* Package {{common}}: Can't compare test coverage as base is missing.
* Package {{tomcat}}: Can't compare test coverage as base is missing.
* Package {{security}}: Can't compare test coverage as base is missing.
* Package {{submission/mapreduce}}: Can't compare test coverage as base is 
missing.
* Package {{common-test}}: Can't compare test coverage as base is missing.
* Package {{connector/connector-ftp}}: Can't compare test coverage as base is 
missing.
* Package {{connector/connector-hdfs}}: Can't compare test coverage as base is 
missing.
* Package {{connector/connector-kafka}}: Can't compare test coverage as base is 
missing.
* Package {{connector/connector-sdk}}: Can't compare test coverage as base is 
missing.
* Package {{connector/connector-generic-jdbc}}: Can't compare test coverage as 
base is missing.
* Package {{connector/connector-sftp}}: Can't compare test coverage as base is 
missing.
* Package {{connector/connector-kite}}: Can't compare test coverage as base is 
missing.
* Package {{repository/repository-postgresql}}: Can't compare test coverage as 
base is missing.
* Package {{repository/repository-common}}: Can't compare test coverage as base 
is missing.
* Package {{repository/repository-mysql}}: Can't compare test coverage as base 
is missing.
* Package {{repository/repository-derby}}: Can't compare test coverage as base 
is missing.
* Package {{test}}: Can't compare test coverage as base is missing.
* Package {{client}}: Can't compare test coverage as base is missing.


{color:orange}WARNING:{color} New findbugs warnings 
([report|https://builds.apache.org/job/PreCommit-SQOOP-Build/1608/artifact/patch-process/findbugs_report.txt])
* Package {{shell}}: Can't compare classes as base is missing.
* Package {{execution/mapreduce}}: Can't compare classes as base is missing.
* Package {{server}}: Can't compare classes as base is missing.
* Package {{core}}: Can't compare classes as base is missing.
* Package {{tools}}: Can't compare classes as base is missing.
* Package {{common}}: Can't compare classes as base is missing.
* Package {{tomcat}}: Can't compare classes as base is missing.
* Package {{security}}: Can't compare classes as base is missing.
* Package {{submission/mapreduce}}: Can't compare classes as base is missing.
* Package {{common-test}}: Can't compare classes as base is missing.
* Package {{connector/connector-ftp}}: Can't compare classes as base is missing.
* Package {{connector/connector-hdfs}}: Can't compare classes as base is 
missing.
* Package {{connector/connector-kafka}}: Can't compare classes as base is 
missing.
* Package {{connector/connector-sdk}}: Can't compare classes as base is missing.
* Package {{connector/connector-generic-jdbc}}: Can't compare classes as base 
is missing.
* Package {{connector/connector-sftp}}: Can't compare classes as base is 
missing.
* Package {{connector/connector-kite}}: Can't compare classes as base is 
missing.
* Package {{repository/repository-postgresql}}: Can't compare classes as base 
is missing.
* Package {{repository/repository-common}}: Can't compare classes as base is 
missing.
* Package {{repository/repository-mysql}}: Can't compare classes as base is 
missing.
* Package {{repository/repository-derby}}: Can't compare classes as base is 
missing.
* Package {{test}}: Can't compare classes as base is missing.
* Package {{client}}: Can't compare classes as base is missing.


{color:green}SUCCESS:{color} All integration tests passed (executed 73 tests)

Console output is available 
[here|https://builds.apache.org/job/PreCommit-SQOOP-Build/1608/console].

This message is automatically generated.

> Sqoop2: Generic JDBC: Drop support for specifying custom query when exporting 
> data
> ----------------------------------------------------------------------------------
>
>                 Key: SQOOP-2441
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2441
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2441.patch, SQOOP-2441.patch
>
>
> In the early days of the development we've added new feature to the JDBC 
> connector that enabled user to specify custom query to insert the data - 
> similarly as user can specify custom query to select data. I see several 
> problems with the feature:
> * It's actually not working at all right now because we're not able to 
> [generate schema from the custom 
> query|https://github.com/apache/sqoop/blob/sqoop2/connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcToInitializer.java#L66].
> * It doesn't allow us to do any batching as we're doing in Sqoop 1 when we're 
> putting several rows into the same query which will hurt performance.
> * I did not see any real request for this feature from users
> Hence I would like to propose dropping this unfinished/non-working feature 
> all together. Any thoughts?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to