> On Aug. 20, 2015, 4:02 p.m., Jarek Cecho wrote: > > common/src/main/java/org/apache/sqoop/model/ConfigUtils.java, lines 549-556 > > <https://reviews.apache.org/r/37639/diff/1/?file=1044865#file1044865line549> > > > > It seems that we have this code around a lot, what about moving it to a > > special method that will simply make field accessible and do it in findbugs > > compatible manner?
Thanks for the comment, the patch is updated. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37639/#review95961 ----------------------------------------------------------- On Aug. 21, 2015, 1:54 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37639/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2015, 1:54 a.m.) > > > Review request for Sqoop. > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Fix security problems in ConfigUtils > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/model/ConfigUtils.java 52e7ef6 > > Diff: https://reviews.apache.org/r/37639/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
