----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37718/#review96200 -----------------------------------------------------------
Ship it! Good stuff! connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java (line 42) <https://reviews.apache.org/r/37718/#comment151520> This kind of competes with the normal empty value I think (https://github.com/apache/sqoop/blob/branch-1.99.6/common/src/main/java/org/apache/sqoop/model/ConfigUtils.java#L308). - Abraham Elmahrek On Aug. 24, 2015, 5:19 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37718/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2015, 5:19 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2505 > https://issues.apache.org/jira/browse/SQOOP-2505 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Added config override options. > > > Diffs > ----- > > common/src/main/java/org/apache/sqoop/common/MutableMapContext.java 06ea7a9 > common/src/test/java/org/apache/sqoop/common/TestMutableMapContext.java > 9aab7f8 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsFromInitializer.java > 902549d > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java > 234bb71 > > connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java > b54ad15 > > connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties > 5feae54 > > connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestFromInitializer.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/37718/diff/ > > > Testing > ------- > > Unit and integration tests are passing on my box. > > > Thanks, > > Jarek Cecho > >
