----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37947/#review97987 -----------------------------------------------------------
Ship it! Small nit below, otherwise I'm +1. shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java (line 893) <https://reviews.apache.org/r/37947/#comment154123> Nit: Let's replace the check with StringUtils.isEmpty(nameInput.getValue()) https://commons.apache.org/proper/commons-lang/javadocs/api-2.6/org/apache/commons/lang/StringUtils.html#isEmpty(java.lang.String) Jarcec - Jarek Cecho On Sept. 8, 2015, 12:45 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37947/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2015, 12:45 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2539 > https://issues.apache.org/jira/browse/SQOOP-2539 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Currently resource name such as job name, connector name or link name can be > null. We should enforce that these resource names cannot be null. > > > Diffs > ----- > > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepoUtils.java > df41fb1 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 0b68058 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaUpgradeQuery.java > 6adf959 > > repository/repository-mysql/src/main/java/org/apache/sqoop/repository/mysql/MySqlSchemaCreateQuery.java > 46493a3 > > repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlRepositoryHandler.java > 0d0ea8c > > repository/repository-postgresql/src/main/java/org/apache/sqoop/repository/postgresql/PostgresqlSchemaUpgradeQuery.java > PRE-CREATION > shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java 63b1267 > test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java > 82043ea > test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java > e3e7bfe > test/src/main/java/org/apache/sqoop/test/utils/SqoopUtils.java PRE-CREATION > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_5UpgradeTest.java > PRE-CREATION > > test/src/test/java/org/apache/sqoop/integration/repository/derby/upgrade/Derby1_99_6UpgradeTest.java > PRE-CREATION > test/src/test/resources/repository/derby/derby-repository-1.99.5.tar.gz > PRE-CREATION > test/src/test/resources/repository/derby/derby-repository-1.99.6.tar.gz > PRE-CREATION > > Diff: https://reviews.apache.org/r/37947/diff/ > > > Testing > ------- > > mvn test > > > Thanks, > > Dian Fu > >
