----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38178/#review97989 -----------------------------------------------------------
Ship it! Ship It! - Jarek Cecho On Sept. 8, 2015, 9:55 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38178/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2015, 9:55 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2556 > https://issues.apache.org/jira/browse/SQOOP-2556 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Should declare default constructor private for singleton classes. > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/audit/AuditLoggerManager.java 5e5d7ab > core/src/main/java/org/apache/sqoop/audit/FileAuditLogger.java 42cb330 > core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java b64d6fd > core/src/main/java/org/apache/sqoop/core/SqoopConfiguration.java 8f9c445 > core/src/main/java/org/apache/sqoop/driver/Driver.java 8d490dd > core/src/main/java/org/apache/sqoop/driver/JobManager.java 44416c4 > core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java > 121f388 > core/src/main/java/org/apache/sqoop/security/AuthenticationManager.java > 6b12e9f > core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 203d8b0 > > Diff: https://reviews.apache.org/r/38178/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > >
