----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38089/#review99165 -----------------------------------------------------------
Thanks for submitting this. Please see couple of small issues src/java/org/apache/sqoop/util/HiveUtil.java (line 39) <https://reviews.apache.org/r/38089/#comment156069> None of the following 4 constants are used src/java/org/apache/sqoop/util/HiveUtil.java (line 61) <https://reviews.apache.org/r/38089/#comment156070> Not sure what the long name means - can we have simpler descriptive name - may be split into two and probably add a comment? - Venkat Ranganathan On Sept. 14, 2015, 11:51 p.m., Rakesh Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38089/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2015, 11:51 p.m.) > > > Review request for Sqoop and Venkat Ranganathan. > > > Repository: sqoop-trunk > > > Description > ------- > > Sqoop currently doesnt support creating external tables while importing data > to hcatalog tables. This patch adds support to create hcatalog tables ehile > importing data. > > > Diffs > ----- > > src/docs/user/hcatalog.txt 99ae4f5 > src/java/org/apache/sqoop/SqoopOptions.java ace90fd > src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatUtilities.java 4070c24 > src/java/org/apache/sqoop/tool/BaseSqoopTool.java a7f6aec > src/java/org/apache/sqoop/tool/ImportTool.java 39af42c > src/java/org/apache/sqoop/util/HiveUtil.java PRE-CREATION > src/test/org/apache/sqoop/hcat/HCatalogExportTest.java 8aa0725 > src/test/org/apache/sqoop/hcat/HCatalogImportTest.java d97b870 > src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java 32c267f > src/test/org/apache/sqoop/util/TestHiveUtil.java PRE-CREATION > > Diff: https://reviews.apache.org/r/38089/diff/ > > > Testing > ------- > > YES > > > Thanks, > > Rakesh Sharma > >
