----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38555/#review99754 -----------------------------------------------------------
Provided we fix the InvalidRESTCallsTest that is failing on precommit hook, I'm +1 with one nit: server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java (lines 67 - 68) <https://reviews.apache.org/r/38555/#comment156743> It seems that we're logging the same line twice :) Jarcec - Jarek Cecho On Sept. 21, 2015, 12:39 p.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38555/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2015, 12:39 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2583 > https://issues.apache.org/jira/browse/SQOOP-2583 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > As object names such as job names, link names can contain informal characters > such as whitespace, slashes, it should be encoded in the http request. > > > Diffs > ----- > > > client/src/main/java/org/apache/sqoop/client/request/AuthorizationResourceRequest.java > 0bb9a7f > > client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java > 1094ae8 > > client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java > 8391621 > > client/src/main/java/org/apache/sqoop/client/request/SubmissionResourceRequest.java > f0435ce > common/src/main/java/org/apache/sqoop/utils/UrlSafeUtils.java 369037a > server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java > fe0c4d8 > server/src/main/java/org/apache/sqoop/server/RequestContext.java f8401aa > > test/src/test/java/org/apache/sqoop/integration/server/InformalObjectNameTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/38555/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > >
