----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38458/#review99908 -----------------------------------------------------------
I have just one nit, otherwise looks good to me. common/src/main/java/org/apache/sqoop/utils/ApplicationClassLoader.java (line 38) <https://reviews.apache.org/r/38458/#comment156916> Let's call it "ConnectorClassLoader" since we're gonna use it for connector code? Jarcec - Jarek Cecho On Sept. 18, 2015, 9:02 a.m., Dian Fu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38458/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2015, 9:02 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-2578 > https://issues.apache.org/jira/browse/SQOOP-2578 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > This aim of this JIRA is to port the ApplicationClassLoader in Hadoop into > Sqoop. One of the reason why we don't directly depend on the > ApplicationClassLoader implementation in Hadoop is the implementation in > Hadoop is annotated as unstable. As the code isn't complicated, I'd like to > just port it into Sqoop. > > > Diffs > ----- > > common/pom.xml 748fa7a > common/src/main/java/org/apache/sqoop/utils/ApplicationClassLoader.java > PRE-CREATION > > common/src/main/resources/org.apache.sqoop.application-classloader.properties > PRE-CREATION > common/src/test/java/org/apache/sqoop/utils/TestApplicationClassLoader.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/38458/diff/ > > > Testing > ------- > > > Thanks, > > Dian Fu > >
